-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of template getter in element-mixin.html #5519
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending approval by @rictic
Just to note, the docs currently recommend returning If the strict template changes changed this behavior, we should update the docs, but pinging @kevinpschaaf here in case he has input. |
As I read it, this method can return either undefined or null. undefined if the mixed-in element doesn't have a template, either as a dom-module or inline. null if the mixed-in element explicitly declares a null template, as we recommend that you do if it's an element with no template (like e.g. iron-ajax) I'd prefer:
|
Done. PTAL |
HTMLTemplateElement without ! implicitly means nullable, so I think just removing the ! from the setter parameter type comment is the way to go. Changed both to {HTMLTemplateElement|string}. PTAL |
Fix type of template getter in element-mixin.html
Fixes #5443